feat(login): display notification on bad credentials #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to test this PR without running CRC? I don't have enough RAM on my laptop to run CRC :/ |
|
Sure, just run it with the BasicAuthManager setup again. The notification appears for either form of credentials (Basic or Bearer token).
|
jan-law
reviewed
Aug 30, 2021
|
Correct, 2.0 UI will still forget your credentials. If you need to switch users you can open a new tab or refresh the current one. The UI could save the user's credentials into a cookie or localStorage and have a user menu with logout button, but this just hasn't been implemented. PRs accepted, if you're interested, but if it's going into 2.0 the merge window has become very short :-) |
jan-law
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237