Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reports): cache to sessionStorage #259

Merged
merged 1 commit into from
Aug 31, 2021
Merged

fix(reports): cache to sessionStorage #259

merged 1 commit into from
Aug 31, 2021

Conversation

andrewazores
Copy link
Member

Fixes #258

@andrewazores andrewazores requested a review from jan-law August 30, 2021 19:51
@andrewazores andrewazores force-pushed the inmemory-reports-localstorage branch from 04ef33b to 73d17c0 Compare August 31, 2021 15:17
jan-law
jan-law approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewazores andrewazores merged commit 553f521 into cryostatio:main Aug 31, 2021
@andrewazores andrewazores deleted the inmemory-reports-localstorage branch August 31, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-law jan-law jan-law approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In-memory reports caching is unbounded
2 participants
@andrewazores @jan-law