Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): reset event template search filter when switching targets #273

Merged
merged 3 commits into from
Sep 7, 2021
Merged

fix(events): reset event template search filter when switching targets #273

merged 3 commits into from
Sep 7, 2021

Conversation

hareetd
Copy link
Contributor

@hareetd hareetd commented Sep 3, 2021

Fixes #264

@hareetd hareetd marked this pull request as ready for review September 3, 2021 18:26
@hareetd hareetd requested a review from andrewazores September 3, 2021 18:26
@andrewazores andrewazores merged commit eca4cb6 into cryostatio:main Sep 7, 2021
andrewazores added a commit to andrewazores/cryostat-web that referenced this pull request Sep 7, 2021
cryostatio#273)

* Fix event template search broken when switching targets

* Simplify setting filter text

Co-authored-by: Andrew Azores <aazores@redhat.com>
andrewazores added a commit that referenced this pull request Sep 7, 2021
* fix(recordings):  collapse expanded recording rows when switching targets  (#272)

* Start fix for persistent recording row expansion

* Alternate method to fix persistent rows

* Finish fixing persistent row expansion

* fixup! Finish fixing persistent row expansion

* Make expanded rows for a specific target maintain their state through target switching

Co-authored-by: Andrew Azores <aazores@redhat.com>

* fix(events): reset event template search filter when switching targets (#273)

* Fix event template search broken when switching targets

* Simplify setting filter text

Co-authored-by: Andrew Azores <aazores@redhat.com>

* fix(events): reset event type search filter when switching targets (#274)

* Fix event type search broken when switching targets

* Simplify setting filter text

Co-authored-by: Andrew Azores <aazores@redhat.com>

Co-authored-by: Hareet Dhillon <hdhillon@redhat.com>
@hareetd hareetd deleted the fix-event-template-search branch September 7, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event template search/filter breaks when switching between targets
2 participants