Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AppLayout): remove target from logoProps to prevent opening a new tab #297

Merged
merged 2 commits into from
Sep 27, 2021
Merged

fix(AppLayout): remove target from logoProps to prevent opening a new tab #297

merged 2 commits into from
Sep 27, 2021

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Sep 24, 2021

This one-liner address #296

The target '_blank' opens a new tab when the logo in the top left is clicked, which is probably not desirable. Now it'll just reload the page in place.

@jan-law jan-law self-requested a review September 24, 2021 21:58
jan-law
jan-law approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@jan-law jan-law left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! (FYI I don't have permission to merge)

andrewazores
andrewazores approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewazores andrewazores merged commit 9dd3871 into cryostatio:main Sep 27, 2021
mergify bot pushed a commit that referenced this pull request Sep 27, 2021
@aptmac
fix(AppLayout): remove target from logoProps to prevent opening a new…
37f02cd 
… tab (#297)

Co-authored-by: Andrew Azores <aazores@redhat.com>
(cherry picked from commit 9dd3871)
@mergify mergify bot mentioned this pull request Sep 27, 2021
Merged
andrewazores pushed a commit that referenced this pull request Sep 27, 2021
@mergify @aptmac
fix(AppLayout): remove target from logoProps to prevent opening a new…
4f0125e 
… tab (#297) (#298)

Co-authored-by: Andrew Azores <aazores@redhat.com>
(cherry picked from commit 9dd3871)

Co-authored-by: aptmac <almacdon@redhat.com>
@aptmac aptmac deleted the 296-new-tab branch September 27, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-law jan-law jan-law approved these changes

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
backport fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aptmac @andrewazores @jan-law