Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(websocket): fix repeated disconnect/reconnect spin #342

Merged
merged 1 commit into from
Nov 22, 2021
Merged

fix(websocket): fix repeated disconnect/reconnect spin #342

merged 1 commit into from
Nov 22, 2021

Conversation

andrewazores
Copy link
Member

Fixes #341

@andrewazores andrewazores requested a review from jan-law November 22, 2021 17:33
jan-law
jan-law approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debounce setting is working well. Although I wasn't able to reproduce the bug by closing and re-opening the web-client on the main branch, the fix makes sense.

@andrewazores andrewazores merged commit 956f782 into cryostatio:main Nov 22, 2021
@andrewazores andrewazores deleted the ws-connect-spin branch November 22, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-law jan-law jan-law approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spinning on WebSocket disconnect/reconnect
2 participants
@andrewazores @jan-law