Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(health): handle version separate from Grafana config #370

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

andrewazores
Copy link
Member

Fix a bug where missing jfr-datasource or Grafana dashboard URL configuration caused Cryostat version number to not be populated

Fixes #365

Fix a bug where missing jfr-datasource or Grafana dashboard URL configuration caused Cryostat version number to not be populated
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good to me

src/app/Shared/Services/Api.service.tsx Show resolved Hide resolved
@andrewazores andrewazores merged commit 2217d0a into cryostatio:main Feb 11, 2022
@andrewazores andrewazores deleted the health-error-handling branch February 11, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About modal version string is undefined when Grafana is not configured
3 participants