Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): add template notification handling #371

Merged

Conversation

andrewazores
Copy link
Member

Fixes #349

Since #367 a notification is already shown when uploading or deleting event templates, but this PR adds a specific handler so that the notification is displayed with a nicely formatted title and message.

@andrewazores andrewazores force-pushed the template-notification-message branch from 1a0d0ba to 31e6ab6 Compare February 11, 2022 19:44
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewazores andrewazores merged commit 88d0dd8 into cryostatio:main Feb 14, 2022
@andrewazores andrewazores deleted the template-notification-message branch February 14, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading/deleting Event Templates produces no Notifications
3 participants