Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rules): add UI for displaying automated rules #378

Merged
merged 4 commits into from
Feb 24, 2022
Merged

feat(rules): add UI for displaying automated rules #378

merged 4 commits into from
Feb 24, 2022

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Feb 17, 2022 •
edited
Loading

@andrewazores andrewazores added the feat New feature or request label Feb 17, 2022
jan-law
jan-law reviewed Feb 17, 2022
View reviewed changes
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the code looks good, including the notifications.

src/app/Rules/Rules.tsx Outdated Show resolved Hide resolved
src/app/Rules/Rules.tsx Show resolved Hide resolved
hareetd
hareetd reviewed Feb 17, 2022
View reviewed changes
Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, I just had the one question above.

@andrewazores andrewazores merged commit b6e1c4b into cryostatio:main Feb 24, 2022
@andrewazores andrewazores deleted the auto-rules-display-ui branch February 24, 2022 14:41
@jan-law jan-law mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-law jan-law jan-law approved these changes

@hareetd hareetd hareetd approved these changes

Assignees
No one assigned
Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated Rules read-only view
3 participants
@andrewazores @hareetd @jan-law