Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(credentials): Manage target JMX credentials #389

Merged
merged 10 commits into from
Mar 16, 2022
Merged

feat(credentials): Manage target JMX credentials #389

merged 10 commits into from
Mar 16, 2022

Conversation

jan-law
Copy link
Contributor

@jan-law jan-law commented Mar 14, 2022

Fixes #388
Adds a table listing targets with stored credentials in the Security tab. Also refactors the Security panel to make it easier to add more cards in the future.

image

@jan-law jan-law added the feat New feature or request label Mar 14, 2022
@jan-law jan-law requested a review from andrewazores March 14, 2022 22:20
@jan-law
Copy link
Contributor Author

jan-law commented Mar 14, 2022

Should I go ahead and remove the Delete button in the JMX AuthModal? It seems redundant now that we have a table for deleting credentials. (see #116 (comment)_)

@jan-law jan-law mentioned this pull request Mar 14, 2022
Merged
@andrewazores
Copy link
Member

Should I go ahead and remove the Delete button in the JMX AuthModal? It seems redundant now that we have a table for deleting credentials. (see #116 (comment)_)

Sure, please go ahead.

@jan-law jan-law marked this pull request as ready for review March 16, 2022 15:59
jan-law
jan-law commented Mar 16, 2022
View reviewed changes
Copy link
Contributor Author

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my one question about tabbing through the CreateJmxCredentialModal, this PR is ready for review

src/app/SecurityPanel/CreateJmxCredentialModal.tsx Show resolved Hide resolved
@andrewazores andrewazores merged commit 4d04a38 into cryostatio:main Mar 16, 2022
@jan-law jan-law deleted the credentials branch March 16, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI for storing and removing JMX credentials
2 participants
@jan-law @andrewazores