Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): handle labels nested within metadata #391

Merged

Conversation

andrewazores
Copy link
Member

Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that I configured the frontend label validation to exclude commas and equal signs. We should probably make the validations more lenient to accommodate template=Profiling,type=TARGET:
https://github.com/cryostatio/cryostat-web/blob/main/src/app/CreateRecording/EditRecordingLabels.tsx#L65

@andrewazores
Copy link
Member Author

I realized that I configured the frontend label validation to exclude commas and equal signs. We should probably make the validations more lenient to accommodate template=Profiling,type=TARGET: https://github.com/cryostatio/cryostat-web/blob/main/src/app/CreateRecording/EditRecordingLabels.tsx#L65

I'm thinking maybe we just want to enforce no whitespace. Using a regex like this is also forcing users into the Latin alphabet, and right now they also can't enter labels with a / or other plausibly desirable characters.

That validation should also be enforced on the backend side too, not just in the frontend form. I'll file a separate issue.

@andrewazores andrewazores merged commit 8176e64 into cryostatio:main Mar 17, 2022
@andrewazores andrewazores deleted the recording-metadata-notifications branch March 17, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants