Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loading): ensure loading spinners are displayed #412

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

andrewazores
Copy link
Member

Fixes #411

  • fix(security): jmx credentials view displays loading spinner
  • fix(recordings): table toolbars remain visible while loading
  • fix(rules): display loading spinner
  • fix(templates): table toolbar remains visible while loading

allows actions such as creation, upload to be triggered while content view is still loading
allows event templates to be uploaded while content view is still loading
Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewazores andrewazores merged commit a83c895 into cryostatio:main Apr 21, 2022
@andrewazores andrewazores deleted the loading-states branch April 21, 2022 21:51
mergify bot pushed a commit that referenced this pull request Apr 21, 2022
* fix(security): jmx credentials view displays loading spinner

* fix(recordings): table toolbars remain visible while loading

allows actions such as creation, upload to be triggered while content view is still loading

* fix(rules): display loading spinner

* fix(templates): table toolbar remains visible while loading

allows event templates to be uploaded while content view is still loading

(cherry picked from commit a83c895)
andrewazores added a commit that referenced this pull request Apr 21, 2022
* fix(security): jmx credentials view displays loading spinner

* fix(recordings): table toolbars remain visible while loading

allows actions such as creation, upload to be triggered while content view is still loading

* fix(rules): display loading spinner

* fix(templates): table toolbar remains visible while loading

allows event templates to be uploaded while content view is still loading

(cherry picked from commit a83c895)

Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JMX Credentials and Automated Rules UIs do not display loading spinners
3 participants