-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(loading): ensure loading spinners are displayed #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows actions such as creation, upload to be triggered while content view is still loading
allows event templates to be uploaded while content view is still loading
hareetd
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
jan-law
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Apr 21, 2022
* fix(security): jmx credentials view displays loading spinner * fix(recordings): table toolbars remain visible while loading allows actions such as creation, upload to be triggered while content view is still loading * fix(rules): display loading spinner * fix(templates): table toolbar remains visible while loading allows event templates to be uploaded while content view is still loading (cherry picked from commit a83c895)
andrewazores
added a commit
that referenced
this pull request
Apr 21, 2022
* fix(security): jmx credentials view displays loading spinner * fix(recordings): table toolbars remain visible while loading allows actions such as creation, upload to be triggered while content view is still loading * fix(rules): display loading spinner * fix(templates): table toolbar remains visible while loading allows event templates to be uploaded while content view is still loading (cherry picked from commit a83c895) Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411