fix(labels): Prevent duplicate labels POST call #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
approved these changes
Apr 27, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 27, 2022
* fix(labels): Prevent duplicate labels POST call * Refresh labels only for same target (cherry picked from commit 5a9b7be)
andrewazores
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409 - the
target.target()Observable inpostTargetRecordingMetadataseemed to be firing twice.I also noticed the metadata labels notification subscription didn't check if the notification applied to the selected target. Added a check to prevent unnecessary computation when receiving metadata label notifications.
This fix prevents an error toast from popping up but leaves the state otherwise unchanged. Up to you if you want to backport it.