Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(navigation): fix unncessary page refresh when following breadcrumbs #460

Merged
merged 1 commit into from
Jun 14, 2022
Merged

fix(navigation): fix unncessary page refresh when following breadcrumbs #460

merged 1 commit into from
Jun 14, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jun 14, 2022

Fixes #459

Fixes view refresh taking a long time when following breadcrumbs.

@tthvo tthvo added the bug Something isn't working label Jun 14, 2022
@tthvo tthvo requested a review from andrewazores June 14, 2022 02:38
@tthvo
Copy link
Member Author

tthvo commented Jun 14, 2022 •
edited
Loading

I chose the <Link> approach since I think it would be a more centralized fix. I read the history router approach but it seems we need to check and pass correct callbacks to onclick. What do you think?

@andrewazores andrewazores merged commit 80bf423 into cryostatio:main Jun 14, 2022
@tthvo tthvo deleted the fix-breadcrumb-reload branch June 14, 2022 14:41
@tthvo tthvo mentioned this pull request Nov 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Longer reload time when following breadcrumbs
2 participants
@tthvo @andrewazores