Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(security): use API v2.2 JMX credentials #475

Merged

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jun 28, 2022

Related to #465
Fixes #474

switch API requests to v2.2, matchExpression-based credentials definitions.

This doesn't make any user-visible changes - the Jest snapshot is even unchanged. Just switches the API backend to the new v2.2 version and corrects notification handling behaviour etc so that https://github.com/cryostatio/cryostat/pull/1000 doesn't break this view.

@andrewazores andrewazores added the feat New feature or request label Jun 28, 2022
@andrewazores andrewazores force-pushed the credentials-matchexpression branch 2 times, most recently from b1890c2 to 774ed8e Compare June 28, 2022 19:47
switch API requests to v2.2, matchExpression-based credentials definitions
@andrewazores andrewazores force-pushed the credentials-matchexpression branch from 774ed8e to 570337b Compare June 28, 2022 19:53
Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@andrewazores andrewazores merged commit b1c98b0 into cryostatio:main Jun 29, 2022
@andrewazores andrewazores deleted the credentials-matchexpression branch June 29, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Multiple JMX Credentials for a target JVM with the same target alias
2 participants