Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package.json): fix broken prettier config, add other useful scripts #478

Merged
merged 15 commits into from
Sep 27, 2022
Merged

fix(package.json): fix broken prettier config, add other useful scripts #478

merged 15 commits into from
Sep 27, 2022

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jul 5, 2022 •
edited
Loading

Fixes #477
Depends on #473 #463 #431

  • fix(package.json): quote prettier targets
  • split format into format:apply
  • add check-only format script
  • don't re-exec npm directly, use execpath
  • reorder license check/apply
  • use npm-run-all
  • linting also runs format check
  • also lint .ts
  • add script to apply lint fixes
  • ci checks code format, not only license

@andrewazores
Copy link
Member Author

CI will fail on this until I run the format:apply script, but that will likely cause a painful rebase for other open PRs (#473 #463 #431). I'll wait until those are in before applying formatting in this PR and opening it for review/merge.

@andrewazores andrewazores mentioned this pull request Jul 5, 2022
Merged
@andrewazores andrewazores mentioned this pull request Jul 14, 2022
Merged
@maxcao13 maxcao13 mentioned this pull request Aug 8, 2022
Open
@github-actions
Copy link

This PR/issue depends on:

tthvo
tthvo reviewed Sep 27, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
tthvo
tthvo reviewed Sep 27, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
tthvo
tthvo reviewed Sep 27, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
tthvo
tthvo approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! These scripts will be super helpful!

@andrewazores andrewazores merged commit ec23856 into cryostatio:main Sep 27, 2022
@andrewazores andrewazores deleted the prettier-sources branch September 27, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo approved these changes

@maxcao13 maxcao13 Awaiting requested review from maxcao13

Assignees
No one assigned
Labels
build fix
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm run format doesn't check or format any source files
2 participants
@andrewazores @tthvo