Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(config): add build properties JSON file #547

Merged
merged 2 commits into from
Oct 11, 2022
Merged

build(config): add build properties JSON file #547

merged 2 commits into from
Oct 11, 2022

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Oct 11, 2022 •
edited by tthvo
Loading

Fixes #548

Easy build-time overriding of distribution URLs for bug trackers, mailing list, product name, etc.

@andrewazores
build(config): add build properties JSON file
e5c2709 
Easy build-time overriding of distribution URLs for bug trackers, mailing list, product name, etc.
@andrewazores andrewazores requested review from ebaron and tthvo October 11, 2022 16:43
@tthvo tthvo added the feat New feature or request label Oct 11, 2022
tthvo
tthvo previously approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Worked for me :D I just file an issue and reference it here.

ebaron
ebaron reviewed Oct 11, 2022
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! How easy would it be to customize the version link as well? For downstream builds I patch out the link since the commit hash does not refer to an upstream commit. Is it possible to make it a URL parameter in the JSON file and if empty/unset the href is omitted?

@andrewazores
Copy link
Member Author

Looks good! How easy would it be to customize the version link as well? For downstream builds I patch out the link since the commit hash does not refer to an upstream commit. Is it possible to make it a URL parameter in the JSON file and if empty/unset the href is omitted?

If I understood correctly, the last commit makes this easy now. Just patch the build.json and set "commitHashUrl": "" and the text component will simply render the version string reported by the backend, with no linking to the upstream repo.

ebaron
ebaron approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that as well, that's exactly what I had in mind.

@andrewazores andrewazores merged commit 4fbd51e into cryostatio:main Oct 11, 2022
@andrewazores andrewazores deleted the build-override-about branch October 11, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@tthvo tthvo tthvo left review comments

Assignees
No one assigned
Labels
build feat New feature or request
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Add build properties file
3 participants
@andrewazores @ebaron @tthvo