Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): fix datetimepicker error text alignments #574

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Oct 26, 2022

Fixes #570

Correctly aligned toolbar items when there is an error text in Datetime Picker. A couple refactoring and quick hack with align-self and InputGroup solved the issue.

Screenshot from 2022-10-26 18-59-41

@tthvo tthvo added the fix label Oct 26, 2022
@tthvo tthvo force-pushed the correct-error-text-alignments branch from cbfca53 to ba6363b Compare October 26, 2022 23:09
Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good work!

@andrewazores andrewazores force-pushed the correct-error-text-alignments branch from ba6363b to ec5a27e Compare October 27, 2022 14:10
@andrewazores andrewazores merged commit b88433f into cryostatio:main Oct 27, 2022
mergify bot pushed a commit that referenced this pull request Oct 27, 2022
andrewazores pushed a commit that referenced this pull request Oct 27, 2022
(cherry picked from commit b88433f)

Co-authored-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo deleted the correct-error-text-alignments branch October 27, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Invalid datetime input causes misalignments in toolbar layout
3 participants