fix(agent): add margin bottom for probe template table #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
approved these changes
Oct 28, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
(cherry picked from commit 4a11989)
andrewazores
pushed a commit
that referenced
this pull request
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #583
Related to #584
As a temporary solution, the Probe Template table now has a margin bottom to allow the action menu of the last row to be in viewport.
I used
1.5emfor bottom, just enough to get the menu in viewport but still looks symmetric with top padding/margin.Looks like if the xml spans more than 3 rows, the out-of-view-port is not an issue anymore.