Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(labeler): fix labeler config file name #699

Merged
merged 5 commits into from
Dec 1, 2022

Conversation

maxcao13
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #696

Description of the change:

Fix labeler config file to be named correctly.

Motivation for the change:

This is because it was named like .labeler.yml when it should be labeler.yml

How to manually test:

Look at maxcao13#4 and notice that the action succeeds.
HOWEVER, I'm not sure if it actually works because it doesn't not apply any labels but I'm not sure if that's because it is on a fork. There are some issues within the action labeler repo that talk about how this doesn't work on forks.

@maxcao13 maxcao13 added chore Refactor, rename, cleanup, etc. fix labels Nov 30, 2022
@maxcao13 maxcao13 changed the title Issue fix(labeler): fix labeler config file name Nov 30, 2022
@maxcao13
Copy link
Member Author

Have to override the action then to merge...

@andrewazores andrewazores merged commit 96acd96 into cryostatio:main Dec 1, 2022
@maxcao13 maxcao13 deleted the issue branch December 1, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. fix
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Revert adding needs-triage to pull requests
2 participants