Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(topology): add missing callbacks to empty state actions #917

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix(topology): add missing callbacks to empty state actions #917

merged 1 commit into from
Mar 21, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Mar 21, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Related to: #891

Description of the change:

Added missing callback to empty state

Motivation for the change:

Empty state actions should perform work as expected.

How to manually test:

  1. Go to Topology -> Select listview -> type any words in search bar -> clear searches
  2. Go to Topology -> Select graphview -> choose a bad filter (a target + a group not containing the target) -> clear filters.

@tthvo tthvo added the fix label Mar 21, 2023
@tthvo tthvo requested review from andrewazores and maxcao13 March 21, 2023 20:47
@mergify mergify bot added the safe-to-test label Mar 21, 2023
@tthvo tthvo force-pushed the topology-empty-state branch from 9e3ee63 to f72ca9f Compare March 21, 2023 20:53
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-917-f72ca9fd2896f10e62db37f31de4847c11b405fb sh smoketest.sh

@tthvo tthvo force-pushed the topology-empty-state branch from f72ca9f to c5f8c9c Compare March 21, 2023 21:14
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-917-c5f8c9c10513dc1cc66529464f866d83f4b5bb1e sh smoketest.sh

@tthvo tthvo force-pushed the topology-empty-state branch from c5f8c9c to 5c7a456 Compare March 21, 2023 21:21
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-917-5c7a45684cf5b814bf708916313dd786b7ed24a6 sh smoketest.sh

fix(topology): add missing callbacks to empty state actions
0a7c593 
Signed-off-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo force-pushed the topology-empty-state branch from 5c7a456 to 0a7c593 Compare March 21, 2023 21:29
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-917-0a7c593b52ce6e67605e118c1fdf4f37cb01f247 sh smoketest.sh

@andrewazores andrewazores merged commit 3912e4c into cryostatio:main Mar 21, 2023
@tthvo tthvo deleted the topology-empty-state branch March 21, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@maxcao13 maxcao13 Awaiting requested review from maxcao13

Assignees
No one assigned
Labels
fix safe-to-test
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthvo @andrewazores