Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quickstarts): topology quickstarts #953

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Apr 14, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #936
Depends on #969

Description of the change:

  • Added quickstarts for Custom Targets
  • Start a recording for a group (e.g. Deployment).
  • Refactor common utils
  • Remove unused quickstarts

Motivation for the change:

Topology View is very much new to users. We should have quickstarts on how to navigate and use this view.

Screenshot from 2023-04-24 23-30-47

@tthvo tthvo added the feat New feature or request label Apr 14, 2023
@mergify mergify bot added the safe-to-test label Apr 14, 2023
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-e076e1053970d72c5c56c40dcd02cd8daa581680 sh smoketest.sh

@tthvo tthvo force-pushed the topology-quickstarts branch from e076e10 to 4db22c5 Compare April 14, 2023 22:20
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-4db22c5c2c575edded0f76b0caea8f6658bff890 sh smoketest.sh

@tthvo
Copy link
Member Author

tthvo commented Apr 15, 2023

This might need pushing over code freeze now :)) Just need more time to think over the content more thoroughly...

@tthvo tthvo force-pushed the topology-quickstarts branch from 4db22c5 to bb260e8 Compare April 16, 2023 01:56
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-bb260e8d3cfd43c5bd2aaac5a7c5e05e193f2b41 sh smoketest.sh

@andrewazores
Copy link
Member

This might need pushing over code freeze now :)) Just need more time to think over the content more thoroughly...

I won't be there, but I suggest you raise this during the next meeting. IMO this can just count as documentation, not "code" per se, so long as it is just adding new Quickstart content and not fundamentally changing anything in there that could destabilize the feature.

@tthvo
Copy link
Member Author

tthvo commented Apr 17, 2023

Ahh thanks! I will put as a note and do some more research this week :))

@tthvo tthvo force-pushed the topology-quickstarts branch from bb260e8 to ba3f73a Compare April 17, 2023 17:29
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-ba3f73a975e61fef25b512027367d08d4cc94a1e sh smoketest.sh

@tthvo tthvo force-pushed the topology-quickstarts branch from ba3f73a to 97d6dc9 Compare April 19, 2023 19:09
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-97d6dc9357e99d31df9475a4b3907b3b362ef0db sh smoketest.sh

@tthvo tthvo force-pushed the topology-quickstarts branch from 97d6dc9 to 43b3f1d Compare April 24, 2023 19:12
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-43b3f1d5e663738375af5a6f627d3f4d6971133e sh smoketest.sh

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-43b3f1d5e663738375af5a6f627d3f4d6971133e sh smoketest.sh

@tthvo tthvo force-pushed the topology-quickstarts branch from 43b3f1d to f526b7e Compare April 24, 2023 23:03
@github-actions
Copy link

This PR/issue depends on:

@tthvo tthvo force-pushed the topology-quickstarts branch from f526b7e to c6f7bf2 Compare April 25, 2023 00:55
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-c6f7bf2283b87f32c345a4b47f8e7b24ab46fb93 sh smoketest.sh

@tthvo tthvo force-pushed the topology-quickstarts branch from c6f7bf2 to 5802903 Compare April 25, 2023 03:32
@tthvo tthvo requested review from andrewazores and maxcao13 April 25, 2023 03:33
@tthvo tthvo marked this pull request as ready for review April 25, 2023 03:33
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-5802903ca972f72758110d14aa5553bdb2005c7d sh smoketest.sh

@andrewazores andrewazores force-pushed the topology-quickstarts branch from 5802903 to 124aea9 Compare April 25, 2023 14:25
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-124aea9f8b730016231d3403a95067feb19db75f sh smoketest.sh

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-953-a912ae67776f37558f5852732eab40c55035f7ee sh smoketest.sh

@andrewazores andrewazores merged commit 7cfae86 into cryostatio:main Apr 25, 2023
mergify bot pushed a commit that referenced this pull request Apr 25, 2023
* feat(quickstarts): topology quickstarts

* minor editing

* more minor edits

---------

Co-authored-by: Andrew Azores <aazores@redhat.com>
(cherry picked from commit 7cfae86)
@tthvo tthvo deleted the topology-quickstarts branch April 25, 2023 15:10
andrewazores pushed a commit that referenced this pull request Apr 25, 2023
* feat(quickstarts): topology quickstarts

* minor editing

* more minor edits

---------

Co-authored-by: Andrew Azores <aazores@redhat.com>
(cherry picked from commit 7cfae86)

Co-authored-by: Thuan Vo <thvo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[Request] Topology Quickstarts
2 participants