Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recordings): use a helpful error messge for http-based targets #954

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Apr 14, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Temporary fixes for #944

Description of the change:

Use a special error message for http-based targets.

Motivation for the change:

See #944

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. Go to Recording tab -> Create Recording -> Select 9988 (http).
  3. See the error message.

Screenshots

Dark Theme Light Theme
Screenshot from 2023-04-14 15-09-20 Screenshot from 2023-04-14 15-09-51

@tthvo
Copy link
Member Author

tthvo commented Apr 14, 2023

I suppose even when Automated Rule is enabled that matches these targets, no recordings will be created anyway?

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-954-f9842057b3c2c1d181e770333d5660e0b2723ef7 sh smoketest.sh

@andrewazores
Copy link
Member

I suppose even when Automated Rule is enabled that matches these targets, no recordings will be created anyway?

Right, it will just fail silently in the background since there will be a server-side exception when it tries to perform the action. Similar to what should happen when creating or activating a rule that matches a target that requires credentials, and there are no valid stored credentials.

@tthvo
Copy link
Member Author

tthvo commented Apr 14, 2023

Make sense thanks!

@andrewazores andrewazores merged commit b8411f9 into cryostatio:main Apr 14, 2023
@tthvo tthvo deleted the agent-error-message branch April 14, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants