Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(topology): listview target details need fixed height #980

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix(topology): listview target details need fixed height #980

merged 1 commit into from
Apr 25, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Apr 25, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Related to #891

Description of the change:

Added a fixed height for entity detail in Topology List View. This allows list view to show JVM detail.

There was a fix for JVM Detail card in #937 but that PR missed the fix for Topology ListView.

Screenshots

Before After
image Screenshot from 2023-04-24 21-52-26

@tthvo tthvo requested review from andrewazores and maxcao13 April 25, 2023 01:06
@mergify mergify bot added the safe-to-test label Apr 25, 2023
@tthvo tthvo changed the title fix(topology): listview target details do not show fix(topology): listview target details need fixed height Apr 25, 2023
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-980-379f104bb046583d80a3764b540bc339a8807c6e sh smoketest.sh

@tthvo tthvo force-pushed the topology-listview branch from 379f104 to f9f4391 Compare April 25, 2023 01:51
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-980-f9f4391c9e4ed679e31290f4a22cd759daf28e2d sh smoketest.sh

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-980-cbd2073372718ab5b06b86eeb65405c9ad35bc4c sh smoketest.sh

@andrewazores andrewazores merged commit 2fa367b into cryostatio:main Apr 25, 2023
mergify bot pushed a commit that referenced this pull request Apr 25, 2023
@mergify
fix(topology): listview target details need fixed height (#980)
aeb4a49 
(cherry picked from commit 2fa367b)
@mergify mergify bot mentioned this pull request Apr 25, 2023
Merged
andrewazores pushed a commit that referenced this pull request Apr 25, 2023
@mergify
fix(topology): listview target details need fixed height (#980) (#986)
147d8d1 
(cherry picked from commit 2fa367b)

Co-authored-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo deleted the topology-listview branch April 25, 2023 15:09
@tthvo tthvo mentioned this pull request Apr 28, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@maxcao13 maxcao13 Awaiting requested review from maxcao13

Assignees
No one assigned
Labels
backport fix safe-to-test
Projects
No open projects
2.3.0 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthvo @andrewazores