Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(about): route /about should show without auth #995

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Apr 25, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #994

Description of the change:

Allow seeing /about route without logging in.

Motivation for the change:

See #994

Screenshots

Screenshot from 2023-04-25 16-06-09

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-995-be8b17581e8cbede9956cf74aa32d7dbe8f83802 sh smoketest.sh

@andrewazores andrewazores merged commit a8d2e77 into cryostatio:main Apr 25, 2023
mergify bot pushed a commit that referenced this pull request Apr 25, 2023
andrewazores pushed a commit that referenced this pull request Apr 25, 2023
(cherry picked from commit a8d2e77)

Co-authored-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo deleted the about-route branch April 26, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] /about route should not require authentication
2 participants