Remove unnecessary try catch

cryostatio · Dec 11, 2024 · 8d64901 · 8d64901
1 parent 4daead9
commit 8d64901
Showing 1 changed file with 13 additions and 17 deletions.
diff --git a/src/main/java/io/cryostat/recordings/LongRunningRequestGenerator.java b/src/main/java/io/cryostat/recordings/LongRunningRequestGenerator.java
@@ -66,25 +66,21 @@ public LongRunningRequestGenerator() {}
 
     @ConsumeEvent(value = ARCHIVE_ADDRESS, blocking = true)
     public void onMessage(ArchiveRequest request) {
+        logger.trace("Job ID: " + request.getId() + " submitted.");
         try {
-            logger.trace("Job ID: " + request.getId() + " submitted.");
-            try {
-                String rec = recordingHelper.archiveRecording(request.recording, null, null).name();
-                logger.trace("Recording archived, firing notification");
-                bus.publish(
-                        MessagingServer.class.getName(),
-                        new Notification(
-                                ARCHIVE_RECORDING_SUCCESS,
-                                Map.of("jobId", request.getId(), "recording", rec)));
-            } catch (Exception e) {
-                logger.warn("Archiving failed");
-                bus.publish(
-                        MessagingServer.class.getName(),
-                        new Notification(ARCHIVE_RECORDING_FAIL, Map.of("jobId", request.getId())));
-                throw new CompletionException(e);
-            }
+            String rec = recordingHelper.archiveRecording(request.recording, null, null).name();
+            logger.trace("Recording archived, firing notification");
+            bus.publish(
+                    MessagingServer.class.getName(),
+                    new Notification(
+                            ARCHIVE_RECORDING_SUCCESS,
+                            Map.of("jobId", request.getId(), "recording", rec)));
         } catch (Exception e) {
-            logger.warn("Exception thrown while servicing request: ", e);
+            logger.warn("Archiving failed");
+            bus.publish(
+                    MessagingServer.class.getName(),
+                    new Notification(ARCHIVE_RECORDING_FAIL, Map.of("jobId", request.getId())));
+            throw new CompletionException(e);
         }
     }