Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] epoll for container discovery is only packaged for amd64 images #372

Closed
andrewazores opened this issue Apr 15, 2024 · 2 comments · Fixed by #373 or #585
Closed

[Bug] epoll for container discovery is only packaged for amd64 images #372

andrewazores opened this issue Apr 15, 2024 · 2 comments · Fixed by #373 or #585
Assignees
Labels
bug Something isn't working build chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file

Comments

@andrewazores
Copy link
Member

Current Behavior

#371 (comment)

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response

Anything else?

No response

@andrewazores andrewazores added bug Something isn't working needs-triage Needs thorough attention from code reviewers dependencies Pull requests that update a dependency file build chore Refactor, rename, cleanup, etc. and removed needs-triage Needs thorough attention from code reviewers labels Apr 15, 2024
@andrewazores andrewazores self-assigned this Apr 15, 2024
@andrewazores
Copy link
Member Author

#373 (comment)

@andrewazores andrewazores reopened this Jul 26, 2024
@andrewazores
Copy link
Member Author

andrewazores commented Jul 26, 2024

Another idea: do an action matrix across the build architectures, then export the image to a tarball and upload that to an artifact named like cryostat-${ref}-${arch}.

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact

Then a new job should follow which depends on the completion of the previous matrix job, and downloads all artifacts that match the cryostat-ref-* pattern. This job will import the image tarballs, create a manifest, add the images to the manifest, and push the manifest to registry.

https://github.com/orgs/community/discussions/42010

This way the builds can be done in parallel on different runners, and the build architecture can be passed directly to mvn -Dbuild.arch instead of using the Dockerfile.builder and the implicit $TARGETARCH, which doesn't seem to be working as intended in the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file
Projects
Status: Done
Status: In Progress
1 participant