-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(multiarch): build archs in separate runners #585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/build_test |
Workflow started at 7/27/2024, 12:40:09 AM. View Actions Run. |
No GraphQL schema changes detected. |
No OpenAPI schema changes detected. |
CI build and push: All tests pass ✅ |
aali309
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes #372
See #373
Description of the change:
As described in #372 (comment).
This ends up being rather similar to how 2.4 was built: https://github.com/cryostatio/cryostat-legacy/blob/b8d239aa4435569b36785d4cf10a79538c06decf/.github/workflows/push-ci.yml#L24
except this approach uses a build matrix instead of hardcoding the arch cases.
Some hacking around with using
docker
instead ofpodman
so that thedocker.buildx
Quarkus container image extension property can be used, and other similar workarounds, are taken here to get things working without needing to upgrade to a newer Quarkus version where thepodman
extension supports setting the platform/architecture differently than the build host. It was simpler in a way with 2.4 since there the image build is a bit more manually/explicitly controlled usingjib
, but this worked out in the end after a lot of tinkering.My testing on an M1 machine, using the image from the sample run below, shows successful loading of netty epoll:
now there is a different permissions error since that machine is using rootfull podman instead of rootless, but the original problem of the native library not being loaded is resolved.
Motivation for the change:
#372 , and faster approach compared to #373
Sample Run
https://github.com/andrewazores/cryostat3/actions/runs/10120899555