✨ Migrate to Omnilock #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
doitian
force-pushed
the
feature/omnilock
branch
from
1a60495 to
65cc8ff
Compare
doitian
force-pushed
the
feature/omnilock
branch
from
65cc8ff to
3d60b25
Compare
doitian
force-pushed
the
feature/omnilock
branch
from
3d60b25 to
9f5a58b
Compare
doitian
force-pushed
the
feature/omnilock
branch
from
9f5a58b to
266b50e
Compare
doitian
force-pushed
the
feature/omnilock
branch
from
266b50e to
d2300dc
Compare
What's changed: - Switch to the deployment information of Omnilock - args: append 00. It is the omni lock flag byte, which indicate there's no advanced omni lock features been used. - `WitnessArgs.lock` size: 65 to 85, this is the size of a `OmnilockWitnessLock` to only save a 65-byte signature. - witness: instead of storing the 65-byte signature directly into `WitnessArgs.lock`, pack it into a `OmnilockWitnessLock`. Omnilock Contract Error Codes For Reference: - 8: args format is wrong - 5: `WitnessArgs.lock` is not a valid `OmnilockWitnessLock`
doitian
force-pushed
the
feature/omnilock
branch
from
d2300dc to
7c8f6c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed:
no advanced omni lock features been used.
WitnessArgs.locksize: 65 to 85, this is the size of aOmnilockWitnessLockto onlysave a 65-byte signature.
WitnessArgs.lock, pack it into aOmnilockWitnessLock.Omnilock Contract Error Codes For Reference:
WitnessArgs.lockis not a validOmnilockWitnessLockAn example deposit in testnet
Omnilock info:
code_hashhash_typetypetx_hashindex0x0dep_typecodeRelated PRs: nervosnetwork/ckb-production-scripts#75
Closes #12