Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Issue/39 autocomplete #172

Closed
wants to merge 2 commits into from
Closed

Issue/39 autocomplete #172

wants to merge 2 commits into from

Conversation

Akida31
Copy link
Contributor

@Akida31 Akida31 commented Jul 21, 2020 •
edited by MarcelCoding
Loading

Description
The autocompletion searches also in the history. Also changed how commands are hidden (attribute instead of excluding by name).

Issue
#39 (probably don't close it -> Addititional Notes)

Testing Instructions

  • write something in the terminal
  • write the beginning again and press [Tab]

Additional Notes

  • fixed typo
  • Should there also a hint about what will be completed? (like in fish)

Merge Instructions (@MarcelCoding)
Please squash this PR

@MarcelCoding MarcelCoding requested review from MaxiHuHe04 and a team July 21, 2020 12:41
@MarcelCoding MarcelCoding linked an issue Jul 21, 2020 that may be closed by this pull request
autocomplete after the first word #39
Open
MarcelCoding
MarcelCoding suggested changes Jul 21, 2020
View reviewed changes
Copy link
Member

@MarcelCoding MarcelCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message removed hardcoded hidden commands into removed hardcoded hidden commands (#39).

@JannikEmmerich
Copy link
Member

Please change the commit message removed hardcoded hidden commands into removed hardcoded hidden commands (#39).

Since the commit has nothing to do with the issue I wouldn't do that.

MarcelCoding
MarcelCoding previously approved these changes Jul 21, 2020
View reviewed changes
@Akida31 Akida31 mentioned this pull request Jan 15, 2021
Closed
@MarcelCoding MarcelCoding requested review from MaxiHuHe04 and removed request for MaxiHuHe04 January 15, 2021 23:37
@MarcelCoding
Copy link
Member

@Akida31 please update/rebase your branch

@JannikEmmerich JannikEmmerich changed the base branch from experimental to master January 15, 2021 23:40
@JannikEmmerich JannikEmmerich dismissed MarcelCoding’s stale review January 15, 2021 23:40

The base branch was changed.

@Akida31
Copy link
Contributor Author

Akida31 commented Jan 16, 2021

@MarcelCoding
I had to recreate the PR because after a half year I deleted my fork and because of that I wasn't able to rebase this PR.

@Akida31 Akida31 mentioned this pull request Jan 16, 2021
Merged
@Akida31
Copy link
Contributor Author

Akida31 commented Jan 16, 2021

Rebased version: #212

@Akida31 Akida31 closed this Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcelCoding MarcelCoding MarcelCoding left review comments

@MaxiHuHe04 MaxiHuHe04 Awaiting requested review from MaxiHuHe04

Assignees

@Akida31 Akida31

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autocomplete after the first word
3 participants
@Akida31 @JannikEmmerich @MarcelCoding