-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update environment variable files in Docker Compose configurations #2
base: master
Are you sure you want to change the base?
Conversation
.env
Outdated
WEB_API_DOMAIN=cryptlex-api.mycompany.com | ||
DASHBOARD_DOMAIN=cryptlex-app.mycompany.com | ||
RELEASE_SERVER_DOMAIN=cryptlex-releases.mycompany.com | ||
WEB_API_DOMAIN=api-test.cryptlex.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the cryptlex.io domain being used here?
.env
Outdated
|
||
# filestore - Minio or AWS S3 | ||
|
||
FILE_STORE_ACCESS_KEY=admin | ||
FILE_STORE_SECRET_KEY=1password | ||
|
||
# Google SSO | ||
|
||
GOOGLE_CLIENT_ID=PASTE_GOOGLE_CLIENT_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this removed
web-api.env
Outdated
RSA_PASSPHRASE=PASTE_RSA_SECRET | ||
APPLICATION_LICENSE_KEY=PASTE_LICENSE_KEY | ||
RSA_PASSPHRASE=aAbBcCdDeEfF | ||
APPLICATION_LICENSE_KEY=A2CE5C-F4A70D-47FF85-261A3B-ACF503-8685C6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why has this file been changed? this leakes the license key and secret in a public repo
docker-compose.yml
Outdated
options: | ||
max-size: "20m" | ||
labels: | ||
- traefik.backend=cryptlex/cryptlex-admin-portal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please clarify why backend uses this value? Have we used this pattern anywhere in the file
docker-compose.yml
Outdated
@@ -150,7 +150,79 @@ services: | |||
- traefik.docker.network=cryptlex-on-premise_backend | |||
- traefik.port=4200 | |||
|
|||
release-server: | |||
admin-portal: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the indentation is incorrect which makes the file invalid. YAML is sensitive to indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check comments
docker-compose.yml
Outdated
environment: | ||
WEB_API_BASE_URL: https://${WEB_API_DOMAIN} | ||
RELEASE_SERVER_BASE_URL: https://${RELEASE_SERVER_DOMAIN} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this extra line
docker-compose.yml
Outdated
environment: | ||
WEB_API_BASE_URL: https://${WEB_API_DOMAIN} | ||
RELEASE_SERVER_BASE_URL: https://${RELEASE_SERVER_DOMAIN} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this extra line
docker-compose.yml
Outdated
environment: | ||
WEB_API_BASE_URL: https://${WEB_API_DOMAIN} | ||
RELEASE_SERVER_BASE_URL: https://${RELEASE_SERVER_DOMAIN} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this extra line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check comments
No description provided.