fix: update environment variable files in Docker Compose configurations #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnan-kamili
reviewed
Mar 1, 2024
.env
Outdated
| WEB_API_DOMAIN=cryptlex-api.mycompany.com | ||
| DASHBOARD_DOMAIN=cryptlex-app.mycompany.com | ||
| RELEASE_SERVER_DOMAIN=cryptlex-releases.mycompany.com | ||
| WEB_API_DOMAIN=api-test.cryptlex.io |
There was a problem hiding this comment.
why is the cryptlex.io domain being used here?
adnan-kamili
reviewed
Mar 1, 2024
.env
Outdated
|
|
||
| # filestore - Minio or AWS S3 | ||
|
|
||
| FILE_STORE_ACCESS_KEY=admin | ||
| FILE_STORE_SECRET_KEY=1password | ||
|
|
||
| # Google SSO | ||
|
|
||
| GOOGLE_CLIENT_ID=PASTE_GOOGLE_CLIENT_ID |
adnan-kamili
reviewed
Mar 1, 2024
web-api.env
Outdated
| RSA_PASSPHRASE=PASTE_RSA_SECRET | ||
| APPLICATION_LICENSE_KEY=PASTE_LICENSE_KEY | ||
| RSA_PASSPHRASE=aAbBcCdDeEfF | ||
| APPLICATION_LICENSE_KEY=A2CE5C-F4A70D-47FF85-261A3B-ACF503-8685C6 |
There was a problem hiding this comment.
why has this file been changed? this leakes the license key and secret in a public repo
adnan-kamili
reviewed
Mar 1, 2024
docker-compose.yml
Outdated
| options: | ||
| max-size: "20m" | ||
| labels: | ||
| - traefik.backend=cryptlex/cryptlex-admin-portal |
There was a problem hiding this comment.
please clarify why backend uses this value? Have we used this pattern anywhere in the file
adnan-kamili
reviewed
Mar 1, 2024
docker-compose.yml
Outdated
| @@ -150,7 +150,79 @@ services: | |||
| - traefik.docker.network=cryptlex-on-premise_backend | |||
| - traefik.port=4200 | |||
|
|
|||
| release-server: | |||
| admin-portal: | |||
There was a problem hiding this comment.
the indentation is incorrect which makes the file invalid. YAML is sensitive to indentation
adnan-kamili
requested changes
Mar 1, 2024
adnan-kamili
reviewed
Mar 6, 2024
docker-compose.yml
Outdated
| environment: | ||
| WEB_API_BASE_URL: https://${WEB_API_DOMAIN} | ||
| RELEASE_SERVER_BASE_URL: https://${RELEASE_SERVER_DOMAIN} | ||
|
|
There was a problem hiding this comment.
remove this extra line
adnan-kamili
reviewed
Mar 6, 2024
docker-compose.yml
Outdated
| environment: | ||
| WEB_API_BASE_URL: https://${WEB_API_DOMAIN} | ||
| RELEASE_SERVER_BASE_URL: https://${RELEASE_SERVER_DOMAIN} | ||
|
|
There was a problem hiding this comment.
remove this extra line
adnan-kamili
reviewed
Mar 6, 2024
docker-compose.yml
Outdated
| environment: | ||
| WEB_API_BASE_URL: https://${WEB_API_DOMAIN} | ||
| RELEASE_SERVER_BASE_URL: https://${RELEASE_SERVER_DOMAIN} | ||
|
|
There was a problem hiding this comment.
remove this extra line
adnan-kamili
requested changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.