This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-387) Client fetches block headers for whole batch before fast forwarding #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e fast forwarding Solution: Changed client code to only fetch block header of last block to check if the batch can be fast-forwarded. This will make fast forwarding much faster.
bors bot
added a commit
that referenced
this pull request
Nov 25, 2019
614: Bump chrono from 0.4.9 to 0.4.10 r=tomtau a=dependabot-preview[bot] Bumps [chrono](https://github.com/chronotope/chrono) from 0.4.9 to 0.4.10. <details> <summary>Changelog</summary> *Sourced from [chrono's changelog](https://github.com/chronotope/chrono/blob/master/CHANGELOG.md).* > ## 0.4.10 > > ### Improvements > > * `DateTime::parse_from_str` is more than 2x faster in some cases. ([@​michalsrb](https://github.com/michalsrb) > [#358](https://github-redirect.dependabot.com/chronotope/chrono/issues/358)) > * Significant improvements to no-std and alloc support (This should also make > many format/serialization operations induce zero unnecessary allocations) > ([@​CryZe](https://github.com/CryZe) [#341](https://github-redirect.dependabot.com/chronotope/chrono/issues/341)) > > ### Features > > * Functions that were accepting `Iterator` of `Item`s (for example > `format_with_items`) now accept `Iterator` of `Borrow<Item>`, so one can > use values or references. ([@​michalsrb](https://github.com/michalsrb) [#358](https://github-redirect.dependabot.com/chronotope/chrono/issues/358)) > * Add built-in support for structs with nested `Option<Datetime>` etc fields > ([@​manifest](https://github.com/manifest) [#302](https://github-redirect.dependabot.com/chronotope/chrono/issues/302)) > > ### Internal/doc improvements > > * Use markdown footnotes on the `strftime` docs page ([@​qudlibetor](https://github.com/qudlibetor) [#359](https://github-redirect.dependabot.com/chronotope/chrono/issues/359)) > * Migrate from `try!` -> `?` (question mark) because it is now emitting > deprecation warnings and has been stable since rustc 1.13.0 > * Deny dead code </details> <details> <summary>Commits</summary> - [`5905935`](chronotope/chrono@5905935) Merge pull request [#361](https://github-redirect.dependabot.com/chronotope/chrono/issues/361) from quodlibetor/deny-dead-code - [`41700d1`](chronotope/chrono@41700d1) Remove unused constant, deny(dead_code) - [`5b4fc23`](chronotope/chrono@5b4fc23) Merge pull request [#360](https://github-redirect.dependabot.com/chronotope/chrono/issues/360) from quodlibetor/chrono-0_4_10 - [`288f1dd`](chronotope/chrono@288f1dd) Merge pull request [#356](https://github-redirect.dependabot.com/chronotope/chrono/issues/356) from quodlibetor/num_days_from_epoch-docs - [`670561b`](chronotope/chrono@670561b) Prepare for and Bump Chrono version to 0.4.10 - [`6622bdc`](chronotope/chrono@6622bdc) Replace all uses of `try!` with question mark - [`46f8267`](chronotope/chrono@46f8267) Merge pull request [#358](https://github-redirect.dependabot.com/chronotope/chrono/issues/358) from michalsrb/optimize-parsing - [`b717e04`](chronotope/chrono@b717e04) Handle some semantic merge conflicts - [`27f5e5e`](chronotope/chrono@27f5e5e) Temporarily globally allow deprecated - [`0b8c248`](chronotope/chrono@0b8c248) Fix build with rust 1.13.0 - Additional commits viewable in [compare view](chronotope/chrono@v0.4.9...v0.4.10) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=chrono&package-manager=cargo&previous-version=0.4.9&new-version=0.4.10) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Changed client code to only fetch block header of last block to check if the batch can be fast-forwarded. This will make fast forwarding much faster.