Problem: client code uses a custom tendermint client (CRO-101)

[tomtau]

Solution: migrated code to tendermint-rs

[codecov]

Codecov Report

Merging #571 into master will increase coverage by 0.18%.
The diff coverage is 68.8%.

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   67.97%   68.16%   +0.18%     
==========================================
  Files         124      121       -3     
  Lines       14722    14636      -86     
==========================================
- Hits        10008     9976      -32     
+ Misses       4714     4660      -54

Impacted Files	Coverage Δ
client-cli/src/command.rs	0% <ø> (ø)	⬆️
client-rpc/src/server.rs	9.17% <ø> (ø)	⬆️
client-rpc/src/rpc/wallet_rpc.rs	71.91% <0%> (+0.18%)	⬆️
client-core/src/wallet/default_wallet_client.rs	59.12% <0%> (ø)	⬆️
...lient-common/src/tendermint/unauthorized_client.rs	0% <0%> (ø)	⬆️
client-core/src/synchronizer/auto_sync_core.rs	43.96% <0%> (+0.43%)	⬆️
client-common/src/block_header.rs	0% <0%> (ø)	⬆️
...ient-common/src/tendermint/websocket_rpc_client.rs	0% <0%> (ø)	⬆️
client-rpc/src/rpc/multisig_rpc.rs	33.99% <0%> (ø)	⬆️
client-core/src/handler/default_block_handler.rs	90.51% <100%> (ø)	⬆️
... and 15 more

[tomtau]

wait for @devashishdxt to check, but i guess it's ok to go (as an intermediate step before adding the lite client)?

[yihuang]

Yeah, I think so.

[devashishdxt]

Looks good to me. Just one question: Does this use Json RPC over websockets or HTTP?

[yihuang]

The Client trait is basically the same as before, both http and websocket implementation. Only migrated the data types.

[tomtau]

bors try

[devashishdxt]

The Client trait is basically the same as before, both http and websocket implementation. Only migrated the data types.

Then, I think, we should modify the pull request title.

[yihuang]

The Client trait is basically the same as before, both http and websocket implementation. Only migrated the data types.

Then, I think, we should modify the pull request title.

I edited the commit message to include this information.

[bors]

try

Build failed

• continuous-integration/travis-ci/push

[tomtau]

bors r+

[bors]

Merge conflict (retrying...)

[bors]

Build failed (retrying...)

• continuous-integration/travis-ci/push

[tomtau]

bors r-

[bors]

Canceled

[tomtau]

@yihuang seems based on the integration test: https://travis-ci.org/crypto-com/chain/jobs/611272489#L2007
that the client expect code field in the response, but that may be optional?

[yihuang]

@yihuang seems based on the integration test: https://travis-ci.org/crypto-com/chain/jobs/611272489#L2007
that the client expect code field in the response, but that may be optional?

abci_query does need to return a code field, is it testing tendermint rpc node?

[tomtau]

@yihuang seems based on the integration test: https://travis-ci.org/crypto-com/chain/jobs/611272489#L2007
that the client expect code field in the response, but that may be optional?

abci_query does need to return a code field, is it testing tendermint rpc node?

yeah, it's running Tendermint (0.32)

[yihuang]

@yihuang seems based on the integration test: https://travis-ci.org/crypto-com/chain/jobs/611272489#L2007
that the client expect code field in the response, but that may be optional?

abci_query does need to return a code field, is it testing tendermint rpc node?

yeah, it's running Tendermint (0.32)

Except it returns error I guess.

[tomtau]

it may be returning an error -- probably better to run locally and see

[leejw51crypto]

please resubmit again,
ci builder will check

[tomtau]

I can't resolve the conflicts on / push to @yihuang's repo, so closing this PR for now -- feel free to re-open