-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: ibc relayer don't work well with default tx prioritization strategy #848
Conversation
…trategy Solution: - Change the default priority mechanism to be based on gas price
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
==========================================
+ Coverage 18.93% 19.02% +0.08%
==========================================
Files 93 94 +1
Lines 11865 11889 +24
==========================================
+ Hits 2247 2262 +15
- Misses 9136 9142 +6
- Partials 482 485 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
should this one: #846 be merged first? |
no, prioritization don't need any change at relayer side, we just calculate the priority based on gas price rather than fee, relayer always use a static gas price. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks all right, the integration test may need to update pystarport or what the root cause for that failed transfer is
…trategy (crypto-org-chain#848) * Problem: ibc relayer don't work well with default tx prioritization strategy Solution: - Change the default priority mechanism to be based on gas price * add priority integration test * Update app/validator_tx_fee.go * fix integration test * fix integration test * Update app/validator_tx_fee.go
…trategy (#848) * Problem: ibc relayer don't work well with default tx prioritization strategy Solution: - Change the default priority mechanism to be based on gas price * add priority integration test * Update app/validator_tx_fee.go * fix integration test * fix integration test * Update app/validator_tx_fee.go
Solution:
it'll be the default behavior in next SDK version: cosmos/cosmos-sdk#12953
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)