Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: tx inclusion logic when block gas limit exceeded is not tested #379

Closed
yihuang opened this issue Mar 7, 2022 · 0 comments · Fixed by #380
Closed

Problem: tx inclusion logic when block gas limit exceeded is not tested #379

yihuang opened this issue Mar 7, 2022 · 0 comments · Fixed by #380
Assignees
@yihuang

Comments

@yihuang
Copy link
Collaborator

yihuang commented Mar 7, 2022 •
edited
Loading

Test transaction inclusion works as expected when the block gas limit is exceeded.

  • send multiple heavy txs concurrently, the total gas of them is multiple times of the block gas limit.
  • check that all the transactions are included in consecutive blocks successfully.

The test case is expected to fail before #378, but success after it.
@yihuang yihuang self-assigned this Mar 7, 2022
yihuang added a commit to yihuang/cronos that referenced this issue Mar 7, 2022
@yihuang
Problem: tx inclusion logic when block gas limit exceeded is not tested
6cd9cb3 
Closes: crypto-org-chain#379
Solution:
- add integration test to test tx inclusion logic when block gas limit exceeded.
@yihuang yihuang mentioned this issue Mar 7, 2022
Merged
13 tasks
yihuang added a commit to yihuang/cronos that referenced this issue Mar 7, 2022
@yihuang
Problem: tx inclusion logic when block gas limit exceeded is not tested
6fbadc4 
Closes: crypto-org-chain#379
Solution:
- add integration test to test tx inclusion logic when block gas limit exceeded.
yihuang added a commit to yihuang/cronos that referenced this issue Mar 9, 2022
@yihuang
Problem: tx inclusion logic when block gas limit exceeded is not tested
a29f498 
Closes: crypto-org-chain#379
Solution:
- add integration test to test tx inclusion logic when block gas limit exceeded.
yihuang added a commit that referenced this issue Mar 11, 2022
@yihuang
Problem: tx inclusion logic when block gas limit exceeded is not test…
58085b5 
…ed (#380)

Closes: #379
Solution:
- add integration test to test tx inclusion logic when block gas limit exceeded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yihuang yihuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: tx inclusion logic when block gas limit exceeded is not tested yihuang/cronos
1 participant
@yihuang