Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: memiavl don't support async snapshotting #948

Closed
Tracked by #870
yihuang opened this issue Apr 3, 2023 · 0 comments · Fixed by #959
Closed
Tracked by #870

Problem: memiavl don't support async snapshotting #948

yihuang opened this issue Apr 3, 2023 · 0 comments · Fixed by #959

Comments

@yihuang
Copy link
Collaborator

yihuang commented Apr 3, 2023 •
edited
Loading

we have basic support with WriteSnapshot, but to support async snapshotting, we need:

  • take a in-memory snapshot
    • this means we need to support copy-on-write on the MemNodes.
  • start a go-routine which do the actual snapshot work
  • after the new snapshot created successfully, catch-up with later change sets, and switch.
@yihuang yihuang mentioned this issue Apr 3, 2023
Open
25 tasks
yihuang added a commit to yihuang/cronos that referenced this issue Apr 6, 2023
@yihuang
Problem: memiavl don't support rewrite snapshot at background
565e46d 
Closes: crypto-org-chain#948
Solution:
- support copy-on-write on `MemNode`s
- support snapshot rewrite at background, catch-up and switch in `Commit` event.
@yihuang yihuang mentioned this issue Apr 6, 2023
Merged
13 tasks
yihuang added a commit to yihuang/cronos that referenced this issue Apr 9, 2023
@yihuang
Problem: memiavl don't support rewrite snapshot at background
cd4ce99 
Closes: crypto-org-chain#948
Solution:
- support copy-on-write on `MemNode`s
- support snapshot rewrite at background, catch-up and switch in `Commit` event.

better error handling

temp

fix build

revert snapshot rewrite stuff for now
yihuang added a commit that referenced this issue Apr 10, 2023
@yihuang @mmsqe
Problem: memiavl don't support rewrite snapshot at background (#959)
edb321e 
* Problem: memiavl don't support rewrite snapshot at background

Closes: #948
Solution:
- manage multiple trees(multi-store) together.
- support copy-on-write on `MemNode`s
- support snapshot rewrite at background, catch-up and switch in `Commit` event.
- integrate WAL

Signed-off-by: yihuang <huang@crypto.com>

Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: memiavl don't support rewrite snapshot at background yihuang/cronos
1 participant
@yihuang