Problem: async commit queue size not configurable #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
leejw51crypto,
thomas-nguy and
mmsqe
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ZeroCopy: rs.zeroCopy, | ||
| CreateIfMissing: true, | ||
| InitialStores: initialStores, | ||
| TargetVersion: uint32(version), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
mmsqe
approved these changes
May 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
+ Coverage 46.17% 46.35% +0.18%
==========================================
Files 82 82
Lines 6937 6950 +13
==========================================
+ Hits 3203 3222 +19
+ Misses 3397 3393 -4
+ Partials 337 335 -2
|
Comment on lines
+275
to
+289
| go func() { | ||
| defer close(walQuit) | ||
|
|
||
| for entry := range walChan { | ||
| bz, err := entry.data.Marshal() | ||
| if err != nil { | ||
| walQuit <- err | ||
| return | ||
| } | ||
| if err := db.wal.Write(entry.index, bz); err != nil { | ||
| walQuit <- err | ||
| return | ||
| } | ||
| } | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine
Solution: - change the bool option to int rename WaitAsyncCommit
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
13 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)