Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: dependency replacements are not up-to-date (backport #1048) #1049

Merged
merged 7 commits into from
May 29, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 29, 2023

Solution:

  • sync dependency replacements with cosmos-sdk
  • tag memiavl and store
  • remove unneeded replacements

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- sync dependency replacements with cosmos-sdk
- tag memiavl and store
- remove unneeded replacements
@yihuang yihuang requested a review from a team as a code owner May 29, 2023 06:32
@yihuang yihuang requested review from calvinaco and thomas-nguy and removed request for a team May 29, 2023 06:33
go.mod Show resolved Hide resolved
@yihuang yihuang changed the title Problem: dependency replacements are not up-to-date Problem: dependency replacements are not up-to-date (backport #1048) May 29, 2023
@yihuang yihuang requested a review from mmsqe May 29, 2023 07:47
@yihuang yihuang enabled auto-merge (squash) May 29, 2023 08:28
go.mod Show resolved Hide resolved
@yihuang yihuang merged commit 565fa41 into crypto-org-chain:release/v1.0.x May 29, 2023
@yihuang yihuang deleted the release/v1.0.x branch May 29, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants