-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: memiavl result is different when replaying write-ahead-log #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
JayT106 and
leejw51crypto
and removed request for
a team
June 30, 2023 10:10
yihuang
added a commit
to yihuang/chain-main
that referenced
this pull request
Jun 30, 2023
Solution: - fix in memiavl and update deps, see crypto-org-chain/cronos#1088
Merged
13 tasks
yihuang
commented
Jun 30, 2023
if there are empty values, because protobuf decodes empty value as `nil`. Solution: - make sure empty value is represented as empty slice instead of nil in set operation.
Codecov Report
@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
- Coverage 46.38% 46.18% -0.20%
==========================================
Files 80 80
Lines 7197 7195 -2
==========================================
- Hits 3338 3323 -15
- Misses 3500 3516 +16
+ Partials 359 356 -3
|
mmsqe
approved these changes
Jun 30, 2023
JayT106
approved these changes
Jun 30, 2023
github-merge-queue bot
pushed a commit
to crypto-org-chain/chain-main
that referenced
this pull request
Jul 3, 2023
…995) * Problem: memiavl result is different when replaying write-ahead-log Solution: - fix in memiavl and update deps, see crypto-org-chain/cronos#1088 * update setup
13 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if there are empty values, because protobuf decodes empty value as
nil
.Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)