Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: don't support blocking addresses in mempool #1179

Merged
merged 9 commits into from
Sep 21, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 21, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner September 21, 2023 02:28
@yihuang yihuang requested review from JayT106 and calvinaco and removed request for a team September 21, 2023 02:28
CHANGELOG.md Outdated Show resolved Hide resolved
app/app.go Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #1179 (768b8c1) into main (9364b65) will increase coverage by 34.04%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1179       +/-   ##
=========================================
+ Coverage      0   34.04%   +34.04%     
=========================================
  Files         0      114      +114     
  Lines         0    11245    +11245     
=========================================
+ Hits          0     3828     +3828     
- Misses        0     7040     +7040     
- Partials      0      377      +377     
Files Changed Coverage Δ
app/block_address.go 33.33% <33.33%> (ø)

... and 113 files with indirect coverage changes

Solution:
- update ethermint and cometbft-db
@yihuang yihuang force-pushed the blocked-address branch 2 times, most recently from 961e91d to 0af2783 Compare September 21, 2023 03:13
@yihuang yihuang requested a review from mmsqe September 21, 2023 03:13
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
gomod2nix.toml Outdated Show resolved Hide resolved
yihuang and others added 2 commits September 21, 2023 11:17
Co-authored-by: mmsqe <mavis@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang enabled auto-merge September 21, 2023 03:19
@mmsqe
Copy link
Collaborator

mmsqe commented Sep 21, 2023

Might be better we sync rest cometbft-db in rest submodules

@yihuang
Copy link
Collaborator Author

yihuang commented Sep 21, 2023

Might be better we sync rest cometbft-db in rest submodules

good point, did a few cleanups.

@yihuang yihuang added this pull request to the merge queue Sep 21, 2023
Merged via the queue into crypto-org-chain:main with commit 506c6dd Sep 21, 2023
24 checks passed
@yihuang yihuang deleted the blocked-address branch September 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants