Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: improve permission checking in a few messages #1256

Merged
merged 8 commits into from
Dec 11, 2023

Update x/cronos/keeper/msg_server.go

a30591f
Select commit
Loading
Failed to load commit list.
Merged

Problem: improve permission checking in a few messages #1256

Update x/cronos/keeper/msg_server.go
a30591f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2023 in 0s

35.83% (+19.78%) compared to 36d3268

View this Pull Request on Codecov

35.83% (+19.78%) compared to 36d3268

Details

Codecov Report

Merging #1256 (a30591f) into main (36d3268) will increase coverage by 19.78%.
Report is 1 commits behind head on main.
The diff coverage is 31.81%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1256       +/-   ##
===========================================
+ Coverage   16.04%   35.83%   +19.78%     
===========================================
  Files          80      115       +35     
  Lines        6196    10647     +4451     
===========================================
+ Hits          994     3815     +2821     
- Misses       5122     6456     +1334     
- Partials       80      376      +296     
Files Coverage Δ
x/cronos/simulation/operations.go 0.00% <0.00%> (ø)
x/cronos/keeper/permissions.go 86.95% <70.00%> (+86.95%) ⬆️
x/cronos/keeper/msg_server.go 13.58% <0.00%> (+10.80%) ⬆️

... and 52 files with indirect coverage changes