-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: black list addresses are not logged #1328
Problem: black list addresses are not logged #1328
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.0.x #1328 +/- ##
==================================================
- Coverage 34.13% 27.38% -6.76%
==================================================
Files 30 42 +12
Lines 1497 2542 +1045
==================================================
+ Hits 511 696 +185
- Misses 933 1792 +859
- Partials 53 54 +1 |
Update app/app.go Signed-off-by: yihuang <huang@crypto.com> update log
ee3c41b
to
75eaec1
Compare
c007e11
into
crypto-org-chain:release/v1.0.x
Update app/app.go Signed-off-by: yihuang <huang@crypto.com> update log Problem: blacklist logging visibilty to low (crypto-org-chain#1334) Solution: raised logging severity to 'error' Signed-off-by: Bladerox <perseverance-pool@gmx.de> Co-authored-by: Bladerox <pa.sa95@gmx.de>
* Problem: black list addresses are not logged (#1328) Update app/app.go Signed-off-by: yihuang <huang@crypto.com> update log Problem: blacklist logging visibilty to low (#1334) Solution: raised logging severity to 'error' Signed-off-by: Bladerox <perseverance-pool@gmx.de> Co-authored-by: Bladerox <pa.sa95@gmx.de> * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * bump version * fix conflict * fix build --------- Signed-off-by: Bladerox <perseverance-pool@gmx.de> Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: Bladerox <pa.sa95@gmx.de>
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)