Problem: multi ibc transfer is not tested

[mmsqe]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Enhanced user configuration flexibility in IBC setups.
  • Introduced multi-chain transfers using IBC, including balance checks and transfers.
  • Added new functionalities for querying denom trace and handling event queries in IBC transfers.
  • Expanded environment configuration to support mnemonics for 20 users.

• Tests

  • Added a new test function to validate multi-chain transfers between two specified chains.

[coderabbitai]

Walkthrough

The recent updates enhance the system's flexibility and scalability in handling IBC (Inter-Blockchain Communication) by introducing advanced user configuration options, improving the ibc_transfer function with additional parameters and default values, and enabling multi-chain transfers through new functionalities. These changes streamline the process of managing multiple user configurations and facilitate seamless asset transfers across different blockchain networks, marking a significant improvement in the system's interoperability capabilities.

Changes

File Path	Change Summary
integration_tests/.../ibc.jsonnet	Adds multiple user configurations with names, coin amounts, and mnemonics.
integration_tests/cosmoscli.py	Enhances ibc_transfer with a new parameter, default value, and conditional event querying. Adds ibc_denom_trace function.
integration_tests/ibc_utils.py	Introduces ibc_multi_transfer function for multi-chain transfers.
integration_tests/test_ibc_rly.py	Adds test_ibc_multi function for multi-chain transfer testing.
scripts/.env	Adds mnemonic environment variables for 20 users (USER1 to USER20).

🐇✨
In the realm of chains that stretch and wind,
A rabbit hopped, leaving old ways behind.
With a flick and a hop, through IBC, it leaped,
Across blockchains, where tokens quietly slept.
"To connect and transfer," it cheerfully said,
"Is a journey we'll make, from this code we've spread!"
🚀🌌

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 526bc80 and 8640db2.

Files selected for processing (5)

• integration_tests/configs/ibc.jsonnet (2 hunks)
• integration_tests/cosmoscli.py (3 hunks)
• integration_tests/ibc_utils.py (1 hunks)
• integration_tests/test_ibc_rly.py (2 hunks)
• scripts/.env (1 hunks)

Additional comments: 7

integration_tests/configs/ibc.jsonnet (3)

• 10-17: The dynamic generation of user configurations enhances scalability. Ensure that mnemonic environment variables are securely managed to prevent unauthorized access.
• 86-92: Consistent handling of user configurations across chains is beneficial. As with cronos_777-1, ensure mnemonic environment variables are securely managed.
• 18-18: Configuration adjustments in app-config and genesis for cronos_777-1, as well as settings for chainmain-1 and relayer, appear to align with operational and testing needs. Ensure they adhere to the project's requirements and security standards.

integration_tests/test_ibc_rly.py (1)

• 374-375: The addition of test_ibc_multi is crucial for testing multi-IBC transfers. Ensure the test covers all expected scenarios and includes robust error handling to capture potential failures effectively.

integration_tests/cosmoscli.py (3)

• 841-841: The addition of the event_query_tx_for parameter to the ibc_transfer function introduces conditional event querying based on the transaction response. This is a useful feature for enhanced control over event querying, but it's important to ensure that the default behavior aligns with the expected use cases.
• 846-846: Setting the default "broadcast_mode": "sync" in the ibc_transfer function can impact how transactions are processed. While synchronous broadcasting waits for a CheckTx execution before returning, it's crucial to consider the implications on performance and user experience, especially in high-throughput scenarios.

Consider evaluating the impact of this change on transaction throughput and latency to ensure it aligns with the system's performance goals.

• 869-871: The conditional call to event_query_tx_for based on the response code is a good practice for handling transaction responses dynamically. However, it's essential to ensure that this function is robust and handles all possible response codes appropriately.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8640db2 and 5eecfd1.

Files selected for processing (2)

• integration_tests/configs/ibc.jsonnet (2 hunks)
• scripts/.env (1 hunks)

Files skipped from review as they are similar to previous changes (2)

• integration_tests/configs/ibc.jsonnet
• scripts/.env