Problem: rocksdb is out of date #1378
Conversation
yihuang
requested review from
JayT106 and
calvinaco
and removed request for
a team
WalkthroughThe project has seen substantial improvements, highlighted by upgrading Changes
Recent Review StatusConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (8)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.summemiavl/go.modis excluded by!**/*.modmemiavl/go.sumis excluded by!**/*.sumstore/go.modis excluded by!**/*.modstore/go.sumis excluded by!**/*.sumversiondb/go.modis excluded by!**/*.modversiondb/go.sumis excluded by!**/*.sum
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- gomod2nix.toml (1 hunks)
- nix/rocksdb.nix (4 hunks)
Additional comments not posted (7)
nix/rocksdb.nix (6)
23-29: Updated version to 9.0.0 looks good. Please ensure the provided hash matches the expected value for this version.
44-46: Addition of-faligned-allocationfor Clang compilers is a good practice for memory alignment. Please ensure thorough testing on platforms using Clang.
71-86: Adjustments inpostPatchfor gcc-13 build failures andzstd_INCLUDE_DIRSare noted. Please verify these patches are still necessary for version 9.0.0.
87-92:preInstallsteps for macOS and Linux look well thought out. Please ensure testing on both platforms to confirm expected behavior.
102-116: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [99-105]
postFixupadjustments for.pcfile paths and shared libraries on Darwin are important for integration. Please verify paths and behavior on Darwin.
111-111: Updating thechangeloglink to match the new version is a good practice for keeping users informed.gomod2nix.toml (1)
400-401: The update to the "github.com/linxGnu/grocksdb" module version and hash appears correct and aligns with the PR's objective to update dependencies. Ensure the hash value has been verified for security purposes.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional comments not posted (1)
CHANGELOG.md (1)
7-7: The entry for upgrading rocksdb tov9.0.0is correctly formatted and placed, maintaining consistency with the rest of the changelog. Good job on keeping the documentation up-to-date with the project changes.
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (4)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sumversiondb/go.modis excluded by!**/*.modversiondb/go.sumis excluded by!**/*.sum
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- gomod2nix.toml (2 hunks)
- nix/rocksdb.nix (4 hunks)
Files skipped from review as they are similar to previous changes (2)
- gomod2nix.toml
- nix/rocksdb.nix
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional comments not posted (1)
CHANGELOG.md (1)
7-7: The changelog entry correctly documents the upgrade of rocksdb tov9.0.0. This update aligns with the PR's objective and maintains consistency with the format and structure of previous entries in the changelog.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/lint.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/lint.yml (2)
53-53: Verify the intention behind removing--build-tags $BUILD_TAGSfor linting thememiavldirectory.Ensure that removing the build tags does not inadvertently exclude important code from the linting process.
55-55: Verify the intention behind removing--build-tags $BUILD_TAGSfor linting thestoredirectory.Ensure that removing the build tags does not inadvertently exclude important code from the linting process.
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (4)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sumversiondb/go.modis excluded by!**/*.modversiondb/go.sumis excluded by!**/*.sum
Files selected for processing (4)
- .github/workflows/lint.yml (1 hunks)
- CHANGELOG.md (1 hunks)
- gomod2nix.toml (2 hunks)
- nix/rocksdb.nix (4 hunks)
Files skipped from review as they are similar to previous changes (3)
- .github/workflows/lint.yml
- gomod2nix.toml
- nix/rocksdb.nix
|
should we align memiavl as well? but do we do any db migrate to avoid the invalid nonce err |
they only depends on grocksdb indirectly, not necessary to update manually.
this is needed. |
I got invalid nonce bump from 8.1.1 to 8.3.2 |
yeah, still investigating. |
Solution: - upgrade to v8.11.3 grocksdb v1.8.14 changelog fix build Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> try fix
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Summary by CodeRabbit
v8.11.3for improved store functionality.