Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: no command to patch the duplicated tx situation #522

Merged
merged 6 commits into from
Jun 6, 2022
Merged

Problem: no command to patch the duplicated tx situation #522

merged 6 commits into from
Jun 6, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 30, 2022 •
edited
Loading

Closes: #521
Solution:

  • add reindex-duplicated-tx command

This command should work for the 0.6.x blocks too.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner May 30, 2022 09:23
@yihuang yihuang requested review from JayT106 and adu-crypto and removed request for a team May 30, 2022 09:23
@JayT106
Copy link
Collaborator

JayT106 commented May 30, 2022

LGTM

@thomas-nguy
Copy link
Collaborator

can be refactored with https://github.com/crypto-org-chain/cronos/pull/513/files maybe? seems that there are some shared code.

Also would it also good to have the option to specify a list of block numbers rather than a range?

adu-crypto
adu-crypto approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@adu-crypto adu-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others lgtm

cmd/cronosd/cmd/reindex-duplicated-tx.go Show resolved Hide resolved
@yihuang
Copy link
Collaborator Author

yihuang commented May 31, 2022

can be refactored with https://github.com/crypto-org-chain/cronos/pull/513/files maybe? seems that there are some shared code.

yes, depends on which one get merged first, the other one can reuse the code.

Also would it also good to have the option to specify a list of block numbers rather than a range?

sounds good.

@yihuang yihuang force-pushed the patch-dupliated-tx branch from 0a4a3c1 to a7096e9 Compare June 6, 2022 02:25
@yihuang
Copy link
Collaborator Author

yihuang commented Jun 6, 2022

can be refactored with https://github.com/crypto-org-chain/cronos/pull/513/files maybe? seems that there are some shared code.

done, reused the tmDB from the fix-unlucky-tx command.

@yihuang yihuang merged commit 5c66cd8 into crypto-org-chain:release/v0.7.x Jun 6, 2022
@yihuang yihuang deleted the patch-dupliated-tx branch June 6, 2022 04:13
@coderabbitai coderabbitai bot mentioned this pull request Apr 19, 2024
Merged
13 tasks
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adu-crypto adu-crypto adu-crypto approved these changes

@JayT106 JayT106 Awaiting requested review from JayT106 JayT106 is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yihuang @JayT106 @thomas-nguy @adu-crypto