Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: replay un-protected tx is not rejected #585

Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jul 15, 2022

Solution:

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner July 15, 2022 02:54
@yihuang yihuang requested review from thomas-nguy and adu-crypto and removed request for a team July 15, 2022 02:54
Solution:
- backport a non-breaking version of evmos/ethermint#1124

add integration test
@yihuang yihuang force-pushed the backport-replay-protection branch from 5301a5e to e413854 Compare July 15, 2022 02:56
Copy link
Contributor

@adu-crypto adu-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yihuang yihuang merged commit 21b7bc0 into crypto-org-chain:release/v0.7.x Jul 15, 2022
@yihuang yihuang deleted the backport-replay-protection branch July 15, 2022 07:38
yihuang added a commit to yihuang/cronos that referenced this pull request Jul 18, 2022
yihuang added a commit to yihuang/cronos that referenced this pull request Jul 18, 2022
yihuang added a commit that referenced this pull request Jul 25, 2022
* Problem: Reject replay un-protected tx is not tested (port: #585)

Solution:
- port the integration test from v0.7.x

* fix error message

* fix error message again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants