Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: fixes in ibc-go v5.1 are not included #765

Merged
merged 11 commits into from
Nov 13, 2022
Merged

Problem: fixes in ibc-go v5.1 are not included #765

merged 11 commits into from
Nov 13, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 10, 2022 •
edited
Loading

Solution:

  • make a breaking change to upgrade to ibc-go v5.1.0.
  • make the v1.0.0 upgrade works for both testnet and mainnet.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang
Problem: fixes in ibc-go v5.1 are not included
21d1ee3 
Solution:
- make a breaking change to upgrade to ibc-go `v5.1.0`.
- will do v1.0.0 upgrade on both testnet and mainnet.
yihuang
yihuang commented Nov 10, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang
Update CHANGELOG.md
980d76e 
Signed-off-by: yihuang <huang@crypto.com>
yihuang
yihuang commented Nov 10, 2022
View reviewed changes
go.mod Show resolved Hide resolved
yihuang
yihuang commented Nov 10, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 10, 2022 •
edited
Loading

Codecov Report

Merging #765 (e4c5b7e) into release/v1.0.x (eba04a0) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/v1.0.x     #765   +/-   ##
===============================================
  Coverage           34.71%   34.71%           
===============================================
  Files                  28       28           
  Lines                1475     1475           
===============================================
  Hits                  512      512           
  Misses                910      910           
  Partials               53       53
Impacted Files Coverage Δ
app/upgrades.go 0.00% <0.00%> (ø)

@yihuang yihuang marked this pull request as ready for review November 11, 2022 13:25
@yihuang yihuang requested a review from a team as a code owner November 11, 2022 13:25
@yihuang yihuang requested review from calvinaco, leejw51crypto, JayT106 and mmsqe and removed request for a team November 11, 2022 13:25
yihuang
yihuang commented Nov 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang
Update CHANGELOG.md
700ba30 
Signed-off-by: yihuang <huang@crypto.com>
yihuang
yihuang commented Nov 11, 2022
View reviewed changes
go.mod Show resolved Hide resolved
yihuang
yihuang commented Nov 11, 2022
View reviewed changes
go.mod Show resolved Hide resolved
yihuang
yihuang commented Nov 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang
Update CHANGELOG.md
b0b0c9d 
Signed-off-by: yihuang <huang@crypto.com>
mmsqe
mmsqe reviewed Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a test for the send enabled later?

JayT106
JayT106 reviewed Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@JayT106 JayT106 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just leave some comments.

@yihuang yihuang requested a review from JayT106 November 11, 2022 23:46
@yihuang yihuang requested a review from mmsqe November 11, 2022 23:46
@yihuang yihuang merged commit a6f5bbc into crypto-org-chain:release/v1.0.x Nov 13, 2022
@yihuang yihuang deleted the upgrade-ibc-go branch November 13, 2022 03:46
yihuang added a commit that referenced this pull request Jan 26, 2023
@yihuang @mmsqe @tomtau
Problem: v1.0.x changes are not merged into main (#816)
c6dd8f9 
* Problem: eth_sendTransaction is not tested

* Problem: json-rpc apis fail for legacy blocks after upgrade (#696)

* Problem: json-rpc apis fail for legacy blocks

Solution:
- keep the query handler in cosmos-sdk backward-compatible
- add integration test to check

* update sdk to upstream

* ibc-go to rc2

* Problem: file changes detection in workflow is problematic (backport #703) (#705)

* Problem: file changes detection in workflow is problematic

Solution:
- fix wildcards according the plugin's doc
- reformat python

* fix py-lint

* Problem: after v0.9.0 upgrade eth_call failed on old blocks (backport #713) (#719)

* Problem: after v0.9.0 upgrade eth_call failed on old blocks

Solution:
- make grpc query compatible with old format

* debug

* fix eth_call

* fix gravity upgrade test

* update ethermint to main branch

* update sdk

* Problem: state streamers are not integrated (backport #702) (#721)

Solution:
- integration the basic file streamer

* add integration test

* changelog

* fix build

* fix lint

* fix deliver tx event in cosmos-sdk

* fix integration test

* Update integration_tests/test_streamer.py

Signed-off-by: yihuang <huang@crypto.com>

* update ethermint and fix build

* add a small cli utility into test_streamer.py

* fix integration test

* update sdk to upstream

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: new iavl indexes migration is slow and not optional (#714) (#720)

* Problem: new iavl indexes migration is slow and not optional

Closes: #712
Solution:
- Integrate the option introduced in cosmos-sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: recent dependencies are not used (backport #729) (#730)

* Problem: recent dependencies are not used (backport #729)

Solution:
- update cosmos-sdk to 0.46.2, ibc-go to v5.0.0, ethermint to recent main branch

Update highlights:
- new flag to disable fast node migration
- fix streaming listeners bug
- fix grpc server panic
- fix index-eth-tx error on empty db

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: chain state is inconsistent if upgrade migration is interrupted (#748)

* Problem: chain state is inconsistent if upgrade migration is interrupted

Solution:
- update cosmos-sdk with the fix

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* gomod2nix

* skip streamer test

Signed-off-by: yihuang <huang@crypto.com>

* Problem: recent fixes in dependencies are not included (#752)

* Problem: recent fixes in dependencies are not included

Solution:
- update cosmos-sdk and iavl

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* fix build

Signed-off-by: yihuang <huang@crypto.com>

* Problem: binary version is not bump to v1.0.0 (#753)

* Problem: recent fixes in dependencies are not used (#757)

* Problem: recent fixes in dependencies are not used

Solution:
- cosmos-sdk -> v0.46.4
- ethermint -> main
- ibc-go -> v5.0.1
- add dragonberry ics20 replacement

* maintain ethermint fork

* Problem: gas used is not backward compatible (#760)

Solution:
- revert the changes in ethermint

* Problem: evm execute result is non-deterministic with concurrent grpc query (#761)

* Problem: evm execute result is non-deterministic with concurrent grpc query

Solution:
- update dependencies to include the fix

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update go.mod

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: extra_eips is not cleared on production network (#762)

* Problem: extra_eips is not cleared on production network

Closes: #755
Solution:
- add 1.0.0 upgrade plan to clear it

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update integration_tests/test_upgrade.py

Signed-off-by: yihuang <huang@crypto.com>

* fix integration test

Signed-off-by: yihuang <huang@crypto.com>

* Problem: no error log when iavl set failure trigger app hash mismatch (#763)

* Problem: no error log when iavl set failure trigger app hash mismatch

Solution:
- log the error in cosmos-sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* PR merged

Signed-off-by: yihuang <huang@crypto.com>

* Problem: different result from eth_getProof comparing with Ethereum (#764)

* Problem: different result from eth_getProof comparing with Ethereum

Solution:
- cherry-pick solution from ethermint, thanks @mmsqe

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: nix exceeds github rate limit occationally in CI (backport #766) (#768)

Solution:
- configure access-token
- update the action plugins

* Problem: fixes in ibc-go v5.1 are not included (#765)

* Problem: fixes in ibc-go v5.1 are not included

Solution:
- make a breaking change to upgrade to ibc-go `v5.1.0`.
- will do v1.0.0 upgrade on both testnet and mainnet.

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* fix lint

* include cache fix in tendermint

* update sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* make different plan name v1.0.0-testnet3 for testnet3

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>

* Problem: london hardfork number failed validation (#771)

* fix upgrade set parameters

* changelog

* Problem: formal v0.46.5 cosmos-sdk release is not used (#772)

* Problem: formal v0.46.5 cosmos-sdk release is not used

Solution:
- update dependency, should be non-breaking for cronos

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* update to v0.46.6

Signed-off-by: yihuang <huang@crypto.com>

* Problem: final v1.0.0 is not released (#774)

Solution:
- update changelog

* Problem: manual prune cmd is not included (backport #781) (#782)

Solution:
- add to root cmd

* Problem: cosmos-sdk `v0.46.7` is not used (#790)

* Problem: cosmos-sdk `v0.46.7` is not used

Solution:
- update dependency
- `v0.46.7` fix a gov migration issue which affect query votes of old proposals.

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* use sdk streamers config

* fix streamer test

* fix file streamer integration test

* changelog

Signed-off-by: yihuang <huang@crypto.com>

* Problem: discontinued ibc-go version (#802)

* Problem: discontinued ibc-go version

Solution:
- update ibc-go to v5.2.0.
- do another coordinated upgrade on testnet3.

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update app/upgrades.go

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

* Problem: production rocksdb configuration is not optimal (#813)

* Problem: production rocksdb configuration is not optimal

Solution:
- update related dependencies to allow customize rocksdb options.
- especially using rocksdb v7.
- tune rocksdb options.

* Update Makefile

Signed-off-by: yihuang <huang@crypto.com>

* remove rocksdb from niv

* rocksdb options

* update flake

* fix build

* create_if_missing

* OptimizeLevelStyleCompaction and IncreaseParallelism

* remove SetLevelCompactionDynamicLevelBytes and add BlockCache

* fix integration test

* comments

Signed-off-by: yihuang <huang@crypto.com>

* Problem: prometheus metrics is lost (#814)

* Problem: prometheus metrics is lost

Solution:
- setup correctly in ethermint

* changelog

* release v1.0.3

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* fix changelog

* fix merge

* Update integration_tests/test_upgrade.py

Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Signed-off-by: yihuang <huang@crypto.com>

* fix test

* Update integration_tests/configs/default.jsonnet

Signed-off-by: yihuang <huang@crypto.com>

* fix test_multiple_attestation_processing

* fix changelog

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Apr 19, 2024
Merged
13 tasks
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsqe mmsqe mmsqe approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner automatically assigned from crypto-org-chain/cronos-dev

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto leejw51crypto is a code owner automatically assigned from crypto-org-chain/cronos-dev

@JayT106 JayT106 Awaiting requested review from JayT106

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @mmsqe @JayT106