Problem: memiavl import API not implemented #941
Conversation
yihuang
requested review from
calvinaco and
thomas-nguy
and removed request for
a team
Solution: - implement Import function to convert state-sync snapshot to memiavl snapshot
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| node := &MemNode{ | ||
| height: uint8(n.Height), | ||
| size: 1, | ||
| version: uint32(n.Version), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| i := w.nodeIndex | ||
| w.nodeIndex++ | ||
| return i, nil | ||
| return w.writeBranch(node.Version(), uint32(node.Size()), node.Height(), leftIndex+1, node.Hash()) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| right: rightNode, | ||
| } | ||
| nodeHash := node.Hash() | ||
| idx, err := i.writeBranch(node.version, uint32(node.size), node.height, leftIndex+1, nodeHash) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| rightNode := i.nodeStack[len(i.nodeStack)-1] | ||
|
|
||
| node := &MemNode{ | ||
| height: uint8(n.Height), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| node := &MemNode{ | ||
| height: uint8(n.Height), | ||
| size: leftNode.size + rightNode.size, | ||
| version: uint32(n.Version), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
|
|
||
| if n.Height == 0 { | ||
| node := &MemNode{ | ||
| height: uint8(n.Height), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
|
@mmsqe sorry I did a force push to improve the code reuse, please review again |
| if err := buildIndex(input, kvsIndexFile, snapshotDir, int(t.root.Size())); err != nil { | ||
| // N = 2L-1 | ||
| leaves := (rootIndex + 2) / 2 | ||
| if err := buildIndex(input, kvsIndexFile, dir, int(leaves)); err != nil { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| return errors.New("version overflows uint32") | ||
| } | ||
|
|
||
| return writeSnapshot(dir, uint32(version), writeHashIndex, func(w *snapshotWriter) (uint32, error) { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
Co-authored-by: mmsqe <tqd0800210105@gmail.com> Signed-off-by: yihuang <huang@crypto.com>
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)