-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reject tx with too large gas limit #12
reject tx with too large gas limit #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is that 10000000
gas from? is it the max block gas network parameter? is it possible to fetch the network parameter directly instead?
It's the current max block gas parameter, it's discussed before that this value should be enough for all the known use cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for the hotfix, just one good thing to change is not to have an undocumented magic number in the fix -- instead if the block max gas can be obtained directly from the context (e.<something>
) or have a named constant that has a comment with a link to https://github.com/crypto-org-chain/cronos-mainnet/blob/master/cronosmainnet_25-1/genesis.json#L8
Made a constant for it, and added more comments. |
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)