Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: autocli use wrong clientCtx #464

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 12, 2024

Solution:

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang requested a review from mmsqe April 12, 2024 00:29
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.36%. Comparing base (4e8c133) to head (8d79c35).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #464      +/-   ##
===========================================
+ Coverage    62.94%   63.36%   +0.41%     
===========================================
  Files          127      127              
  Lines        12062     9603    -2459     
===========================================
- Hits          7593     6085    -1508     
+ Misses        3930     2979     -951     
  Partials       539      539              

see 120 files with indirect coverage changes

@@ -351,4 +351,4 @@ def cb(attrs):
proposal = cli.query_proposal(proposal_id)
wait_for_block_time(cli, isoparse(proposal["voting_end_time"]))
proposal = cli.query_proposal(proposal_id)
assert proposal["status"] == status, proposal
assert proposal["status"] == "PROPOSAL_STATUS_PASSED", proposal
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Solution:
- update dependency to include the fix, see cosmos/cosmos-sdk#19060

changelog

fix test
@yihuang yihuang enabled auto-merge (squash) April 12, 2024 01:31
@yihuang yihuang merged commit 86d7868 into crypto-org-chain:develop Apr 12, 2024
37 of 39 checks passed
@yihuang yihuang deleted the fix-autocli branch April 12, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants