Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: cosmos sdk 0.47.1 is not used #219

Merged
merged 5 commits into from
Mar 30, 2023

Conversation

thomas-nguy
Copy link
Collaborator

replace with stable version
replace tendermint dependencies with cometbft

@thomas-nguy thomas-nguy marked this pull request as draft March 23, 2023 08:37
google.golang.org/genproto v0.0.0-20221227171554-f9683d7f8bef
google.golang.org/grpc v1.52.0
github.com/stretchr/testify v1.8.2
github.com/tendermint/tendermint v0.35.9
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed for the v1 types files.

We may just removed them since we dont have to migrate from v1 to v2

@thomas-nguy thomas-nguy marked this pull request as ready for review March 24, 2023 05:20
@thomas-nguy thomas-nguy temporarily deployed to CI March 24, 2023 05:45 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 24, 2023 05:45 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 24, 2023 05:45 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 24, 2023 05:59 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 24, 2023 05:59 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 24, 2023 05:59 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 29, 2023 09:54 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 29, 2023 09:54 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 29, 2023 09:54 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 29, 2023 09:54 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy changed the title Problem: cosmos sdk 0.47.0 is not used Problem: cosmos sdk 0.47.1 is not used Mar 29, 2023
@thomas-nguy thomas-nguy force-pushed the thomas/upgrade-cosmos-sdk-0.47.0 branch 2 times, most recently from 9be1b90 to 9839f3a Compare March 29, 2023 10:11
@thomas-nguy thomas-nguy force-pushed the thomas/upgrade-cosmos-sdk-0.47.0 branch from 9839f3a to 4d7e1a2 Compare March 29, 2023 10:27
@thomas-nguy thomas-nguy temporarily deployed to CI March 29, 2023 10:59 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 29, 2023 10:59 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 29, 2023 10:59 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy temporarily deployed to CI March 29, 2023 10:59 — with GitHub Actions Inactive
@thomas-nguy thomas-nguy requested review from tomtau and yihuang March 29, 2023 11:21
Copy link

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the abci 1.0 stuff be leveraged in GB? e.g. extra mempool prioritisation for attestations or ordering based on the paid fee?

@thomas-nguy
Copy link
Collaborator Author

Should the abci 1.0 stuff be leveraged in GB? e.g. extra mempool prioritisation for attestations or ordering based on the paid fee?

Yes this could be an idea. I think we can always prioritised the gravity bridges attestations & confirmations msgs as they are crucial for the liveness of the bridge.

@thomas-nguy thomas-nguy merged commit 9745abc into v2.0.0-cronos Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants